[energidataservice] Provide work-around for currency issues #16085
Conversation
jlaur
added
bug
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
force-pushed
the
energidataservice-currency-workaround
branch
from
75e459c
to
f1b67ea
Compare
| return new QuantityType<>(price + " " + currency.getSymbol() + "/kWh"); | ||
| } catch (IllegalArgumentException e) { | ||
| logger.trace("Unable to create QuantityType, falling back to DecimalType", e); | ||
| return new DecimalType(price); |
There was a problem hiding this comment.
You could also fall back to CurrencyUnits.BASE_CURRENCY.getSymbol(), which is always available. Or check if the desired unit is available by CurrencyUnits.getInstance().getUnit(String s).
There was a problem hiding this comment.
Thanks. I'm now verifying the unit before trying to instantiate QuantityType from it.
Additionally I will now fallback to currency code if there is no symbol for the currency, although my tests suggest that currency code as unit is not supported. Also I'm now using getSymbol() on the returned Unit rather than Currency.getSymbol(), because that is display unit for the Locale and thus prone to failure (e.g. "$" vs. "US$").
I don't think using base currency is such a good idea, because that would mean explicitly providing a wrong unit. The end result is currently the same though.
There was a problem hiding this comment.
I see this only as a work-around to ensure reliable state updates in 4.1, would you agree? And do you see anything in all this that is worth creating an issue for in core?
We currently have the limitation that the UoM system know only one currency. When this will change, I would somehow expect:
- Always being able to update state for known currencies, even if there is no currency exchange service provided/installed - without risking
IllegalArgumentExceptionbeing thrown. With known currencies, all I mean all defined by ISO 4217. - In this case IMHO it would still be better to keep the source currency unit rather than overwriting by user configured currency unit without converting the amount. I know this contradicts 4.0 UoM because we cannot enforce "target unit", and I don't have a good proposal for tackling that. It's different, because we can always expect to be able to convert °C to °F, but we can't always expect to be able to convert DKK to EUR. And we cannot make the assumption that exchange rate is 100, because then prices will be plain misleading.
- Being able to update state with currency code as unit rather than symbol. When all currencies will become available and we are able to convert between them, symbols can become ambiguous as previously discussed.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/using-the-new-currency-units-of-measurement-in-4-1/152338/17 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/using-the-new-currency-units-of-measurement-in-4-1/152338/22 |
…16085) * Provide work-around for currency issues * Verify unit before trying to instantiate QuantityType Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
This temporary work-around addresses some issues regarding currency support in openhab/openhab-core#3503 and #16070.
See #16070 (comment)
Issues:
LocaleBasedCurrencyProvider) or configured fixed base currency is not DKK (forFixedCurrencyProvider).The provided work-around will ensure that
Numberitems can always be updated, andNumber:EnergyPriceas well, although it cannot be guaranteed to be in the correct currency/unit.